Feature/example expansion: anneal_offset and embedding examples #31
Conversation
randomir
left a comment
randomir
left a comment
There was a problem hiding this comment.
The embedding example is in a decent shape, but the shimming one doesn't run currently, and some clean-up is required. Also, please add release notes.
Co-authored-by: Radomir Stevanovic <radomir.stevanovic@gmail.com>
|
I cannot reproduce the failure of python shim_mca_shim_AO_FB.py under defaults. Can you let me know the error message you are seeing and/or options used. |
The example didn't run due to this, which looks like it's fixed in your latest update. |
randomir
left a comment
randomir
left a comment
There was a problem hiding this comment.
Looks great now, thanks.
One small issue that should probably be handled is the missing (default) schedule file (excel doc). Perhaps note in the docs the user should manually download/provide it? And/or add a CLI arg for the schedule file?
| qpu_anneal_schedule = pd.read_excel( | ||
| fn_schedule, sheet_name="Fast-Annealing Schedule" |
There was a problem hiding this comment.
I assume this line fails if the schedule file is not available? And the default file is not included in the repo.
There was a problem hiding this comment.
I added a file, and documented that it shouldn't be relied upon for high performance.
2 participants
Expand the embedding example.
Add example for anneal_offset and flux_biases shimming in multi-color annealing context.
This pull request replaces #29